[PATCH] D89837: [X86] Error on using h-registers with REX prefix in the assembler instead of leaving it to a fatal error in the encoder.

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3634
+      HReg = Reg;
+    if (X86II::isX86_64NonExtLowByteReg(Reg) || X86II::isX86_64ExtendedReg(Reg))
+      UsesRex = true;
----------------
It seems X86MCCodeEmitter::emitREXPrefix has more detailed check for each form. Especially, the commens says "Emit REX prefix ... 2) non-default operand size". Is it not covered by this case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89837/new/

https://reviews.llvm.org/D89837