[PATCH] D89088: [MBP] Add whole chain to BlockFilterSet instead of individual BB

Guozhi Wei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 17:54:14 PDT 2020


Carrot added a comment.

As jmorse has pointed out, the function layout is incorrect at the assertion time.

I double checked the code in MachineBlockPlacement::buildCFGChains(), the following two lines should never change the first block (assume it is entry) in a function.

  BlockChain &FunctionChain = *BlockToChain[&F->front()];
  buildChain(&F->front(), FunctionChain);

So there is no obvious problem in MBP, without live debugging a test case, it's difficult to guess the root problem.

Could you help to check when block bb.0 is moved below bb.2?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89088/new/

https://reviews.llvm.org/D89088



More information about the llvm-commits mailing list