[PATCH] D89818: [Compile Time] Make it possible to skip redundant debuginst removal

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

IIRC the original motivation for calling RemoveRedundantDbgInsts in MergeBlockIntoPredecessor was to improve compile time. It's been reported that the change inadvertently regressed compile time within SimplifyCFG as well as LoopUnroll. Imo, instead of making all the clients of MergeBlockIntoPredecessor opt-out of something that could be unexpectedly expensive, it would be better if they could opt-in instead (this is the approach taken in D88928 <https://reviews.llvm.org/D88928>). That still leaves open the possibility of making compile-time improvements in a targeted way, based on profiles.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89818/new/

https://reviews.llvm.org/D89818