[PATCH] D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder

Fady Ghanim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 13:21:00 PDT 2020


fghanim added a comment.

In D89671#2340761 <https://reviews.llvm.org/D89671#2340761>, @AMDChirag wrote:

> I have updated the title.

Great .. Thanks!

> Apologies, I am not well versed with this, but could you explain what does LVal being always `constant` mean in this context?

No worries. we are all at different stages of learning. 
Welcome to LLVM. :)

I saw that you always use `createLVal` with a contant value for initialization. So my Questions was are we always going to initialize the `LVal` we created with a constant value or not? because if not, we have the problem I mentioned in the original comment.

> And also, what sort of checks do I add for that?

a simple assert with a "nice descriptive message" or any other more appropriate check you want is good enough;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89671/new/

https://reviews.llvm.org/D89671



More information about the llvm-commits mailing list