[PATCH] D88494: Add "IncludeRemovable" parameter to TargetInstrInfo::DefinesPredicate

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 11:36:45 PDT 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

> but the common instructions are moved to the preceding block, and the IfConversion feasibility is then re-evaluated before any predication is performed.

I don't think that's an accurate description of how it works... but I guess the conclusion is correct: instructions we plan to CSE are treated separately from instructions we plan to predicate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88494/new/

https://reviews.llvm.org/D88494



More information about the llvm-commits mailing list