[PATCH] D89788: [RISCV] Add GHC calling convention

Andreas Schwab via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 10:25:31 PDT 2020


schwab added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2001
+
+  return true; // CC didn't match.
+}
----------------
jrtc27 wrote:
> Shouldn't this be a hard error? Otherwise it'll fall back on the normal C calling convention like for Fast, no?
This will error out in the caller CCState::AnalyzeCallOperands.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89788/new/

https://reviews.llvm.org/D89788



More information about the llvm-commits mailing list