[PATCH] D89751: [ELF] --gdb-index: support --icf={safe,all}

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked an inline comment as done.
MaskRay added a comment.

Thanks!



================
Comment at: lld/test/ELF/gdb-index-icf.s:28
+.section  .debug_abbrev,"", at progbits
+  .byte  1                         # Abbreviation Code
+  .byte  65                        # DW_TAG_type_unit
----------------
grimar wrote:
> `#` -> `##`?
I think we should loose the requirement for comment markers starting in the middle of a line.
This is basically `clang -S -g` produced assembly with a lot of clean-ups. Comments starting in the middle of a line make them immediately stand out, so ## is probably not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89751/new/

https://reviews.llvm.org/D89751