[PATCH] D89798: [SVE][AArch64] Fix TypeSize warning in loop vectorization legality

Peter Waller via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 08:46:39 PDT 2020


peterwaller-arm added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:1020
+        continue;
+      if (isDereferenceableAndAlignedInLoop(LI, TheLoop, SE, *DT))
         SafePointers.insert(LI->getPointerOperand());
----------------
I'd be tempted to make this if (!foo()) continue, so that the "passing" case is in the body of the loop, thus making it straightforward to add or remove conditions from the loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89798/new/

https://reviews.llvm.org/D89798



More information about the llvm-commits mailing list