[PATCH] D89390: [TargetLowering] Update optimization to check for boolean content

Erik Hogeman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 07:34:40 PDT 2020


ErikHogeman added a comment.

In D89390#2341731 <https://reviews.llvm.org/D89390#2341731>, @spatel wrote:

> LGTM - although it would be nicer to add the test first (without this patch), so we see the difference in output.

Ah right, I assumed it would be fine since the instruction diff will be visible in the next patch I will upload. 
If you prefer it I can submit the test first and then the patch as a follow-up, and then a third commit that improves the condition.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89390/new/

https://reviews.llvm.org/D89390



More information about the llvm-commits mailing list