[PATCH] D89170: [AMDGPU] Select flat scratch instructions where available

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 15:55:40 PDT 2020


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:1449
+
+        Register TmpReg = RS->scavengeRegister(RC, MI, 0);
+        FIOp.setReg(TmpReg);
----------------
arsenm wrote:
> What happens if this needs an SGPR spill?
It it can scavenge it it shall be fine as offset shall not change. If not I guess I would need to adjust SP and revert it. I have added FIXME here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89170/new/

https://reviews.llvm.org/D89170



More information about the llvm-commits mailing list