[PATCH] D89701: Fix TypeSize warning in redundant store elimination

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/Redundantstore.ll:38
+; CHECK-LABEL: @redundant_store
+define void @redundant_store(i32* nocapture %x) local_unnamed_addr #0 {
+  %1 = bitcast i32* %x to <vscale x 4 x i32>*
----------------
peterwaller-arm wrote:
> sdesmalen wrote:
> > Missing CHECK lines to check that the optimisation is not applied?
> Is this desirable? For the time being I was trying to prevent the reappearance of the warning. It seems to me that the optimization is legitimate.
I think it's desirable because the code will now do something different (i.e. it will no longer apply the transformation), so that's worth verifying.


================
Comment at: llvm/test/CodeGen/AArch64/sve-redundant-store.ll:19
+  store i32 1, i32* %x, align 4
+  %2 = tail call <vscale x 4 x i32> @llvm.aarch64.sve.dup.x.nxv4i32(i32 0)
+  store <vscale x 4 x i32> %2, <vscale x 4 x i32>* %1, align 16
----------------
nit: you can also pass this as operand to the function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89701/new/

https://reviews.llvm.org/D89701