[PATCH] D89775: [lld][ELF][test] Add additional test coverage for LTO

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

It feels like `common-mixed1.ll` and `common-mixed2.ll` are very similar and can be merged?



================
Comment at: lld/test/ELF/lto/bitcode-wrapper.ll:51
+offset = int(sys.argv[4], 16)
+header = struct.pack('<IIIII', 0x0B17C0DE, 0, offset, len(bitcode), 0)
+with open(sys.argv[2], 'wb') as output:
----------------
I'd comment fields here. They are:
[Magic32, Version32, Offset32, Size32, CPUType32]


================
Comment at: lld/test/ELF/lto/common-mixed2.ll:7
+; RUN: llvm-as %s -o %t1.o
+; RUN: llvm-mc -triple=x86_64-pc-linux %p/Inputs/common-mixed2.s -o %t2.o -filetype=obj
+; RUN: ld.lld %t1.o %t2.o -o %t.so -shared --save-temps
----------------
Perhaps, use `split-file` or just `echo` rather than adding a new tiny input?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89775/new/

https://reviews.llvm.org/D89775