[PATCH] D89754: [AMDGPU] Avoid inserting noops during scheduling

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 02:04:22 PDT 2020


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

Looks good to me.



================
Comment at: llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp:605-633
-      // Combine adjacent s_nops to use the immediate operand encoding how long
-      // to wait.
-      //
-      // s_nop N
-      // s_nop M
-      //  =>
-      // s_nop (N + M)
----------------
Shouldn't this be part of the previous patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89754/new/

https://reviews.llvm.org/D89754



More information about the llvm-commits mailing list