[PATCH] D89753: [HazardRec] Allow inserting multiple wait-states simultaneously

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Looks good modulo comments inline.



================
Comment at: llvm/include/llvm/CodeGen/ScheduleHazardRecognizer.h:120
+  /// instruction stream.
+  virtual void EmitNoops(int WaitStates) {
+    // Default implementation: count it as a cycle.
----------------
I think `unsigned` would make more sense, and `WaitStates` seems like AMDGPU-specific terminology.


================
Comment at: llvm/include/llvm/CodeGen/TargetInstrInfo.h:1349
+                           MachineBasicBlock::iterator MI,
+                           int WaitStates) const;
+
----------------
Likewise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89753/new/

https://reviews.llvm.org/D89753