[PATCH] D89552: ASAN: Support detect_invalid_pointer_pairs=1 with detect_stack_use_after_return=1

Martin Liška via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 20 00:41:16 PDT 2020


marxin marked an inline comment as done.
marxin added inline comments.


================
Comment at: compiler-rt/test/asan/TestCases/invalid-pointer-pairs-subtract-success.cpp:26
 
   // Stack variable.
   char stack[10000];
----------------
kcc wrote:
> kcc wrote:
> > If the behavior depends on the size of the stack variable, I'd prefer to extend the test to have both cases. 
> any thoughts on this comment? 
It does not depend on any size of a stack variable. I thought you mean to run the test-case both with shadow stack and without shadow stack.
That's why I added the another `// RUN` line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89552/new/

https://reviews.llvm.org/D89552



More information about the llvm-commits mailing list