[PATCH] D89742: [FileCollector] Move interface into FileCollectorBase (NFC)

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

In D89742#2340628 <https://reviews.llvm.org/D89742#2340628>, @JDevlieghere wrote:

> In D89742#2340590 <https://reviews.llvm.org/D89742#2340590>, @dexonsmith wrote:
>
>> This mostly looks good, I'm just wondering about tests. I hunted around for a `FileCollector` unit test and didn't see one, but it seems like it might be a good fit, especially if it gets you coverage things otherwise only used in LLDB. WDYT?
>
> I think you might have missed `FileCollectorTest.cpp`. I guess I could add some test for just the base class, but I'm not sure if that would add much value.

Weird, `git grep` seems to be returning different results now :). Agreed, it seems like enough.

This LGTM now with the fix for `override`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89742/new/

https://reviews.llvm.org/D89742