[PATCH] D89730: [NPM] Port module-debuginfo pass to the new pass manager

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 14:19:39 PDT 2020


aeubanks added a comment.

a couple nits, otherwise lgtm



================
Comment at: llvm/include/llvm/Analysis/ModuleDebugInfoPrinter.h:18
+
+class Module;
+
----------------
this shouldn't be needed


================
Comment at: llvm/include/llvm/Analysis/ModuleDebugInfoPrinter.h:22
+    : public PassInfoMixin<ModuleDebugInfoPrinterPass> {
+  llvm::DebugInfoFinder Finder;
+  raw_ostream &OS;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89730/new/

https://reviews.llvm.org/D89730



More information about the llvm-commits mailing list