[PATCH] D89317: [InstructionSimplify] icmp simplification

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 07:05:58 PDT 2020


SjoerdMeijer added a comment.

In D89317#2338631 <https://reviews.llvm.org/D89317#2338631>, @spatel wrote:

> This seems to be missing some other preconditions on the constant values:
> https://rise4fun.com/Alive/EvB

Ah yes! Thanks for checking. It's an off-by-one error, and we need positive constants, so should be: `Pre: C1 < C2 && C1 >= 0`. Will fix this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89317/new/

https://reviews.llvm.org/D89317



More information about the llvm-commits mailing list