[PATCH] D83069: [lit] warn if explicitly specified test won't be run indirectly

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 02:52:54 PDT 2020


thopre added a comment.

LGTM but I'm not familiar with lit to tell whether there would be a more idiomatic way to write this. I also agree with the assumption that invoking lit with a large number of tests arguments rather than a directory is unlikely.



================
Comment at: llvm/utils/lit/tests/discovery.py:144
+#
+# CHECK-ERROR-INDIRECT-RUN-CHECK: error: 'top-level-suite :: test.not-txt' would not be run indirectly
+
----------------
Why not test the full error message?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83069/new/

https://reviews.llvm.org/D83069



More information about the llvm-commits mailing list