[PATCH] D89384: [llvm-readobj/elf] - Change the behavior of handing DT_SONAME.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Looks good, thanks.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/dynamic-tags.test:496-497
+# PHENTSIZE-LLVM:      warning: '[[FILE]]': string table was not found
+# PHENTSIZE-LLVM-NEXT: LoadName: <?>
 # PHENTSIZE-LLVM:      DynamicSection [ (61 entries)
 # PHENTSIZE-LLVM-NEXT:   Tag                Type                 Name/Value
----------------
Maybe worth a blank line between these two to highlight that the `LoadName` printing is not part of the dynamic section printing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89384/new/

https://reviews.llvm.org/D89384