[PATCH] D89665: [LSR] ignore profitable chain optimization when instruction number is the major cost

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 18 20:48:14 PDT 2020


steven.zhang added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:3097
   }
   // Remove any unprofitable chains.
   unsigned ChainIdx = 0;
----------------
I am not familiar with the code logic. But it makes more sense to bail out here when the instruction is the major cost.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89665/new/

https://reviews.llvm.org/D89665



More information about the llvm-commits mailing list