[PATCH] D89599: [AMDGPU] Fixed v_swap_b32 match

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 17 11:52:51 PDT 2020


rampitec added a comment.

In D89599#2336763 <https://reviews.llvm.org/D89599#2336763>, @arsenm wrote:

> Couldn't this try to preserve the implicit operands?

It can be implicit def or implicit kill. In both cases verifier will complain if it is dropped. Then the problem is there can be other instructions in between of the combined three and correct licenses may be needed in that range. That is probably possible to preserve implicit operands on the move at the insertion point and carry it over to the swap, but I am not so sure about the other two. Insert there an IMPLICIT_DEF or KILL?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89599/new/

https://reviews.llvm.org/D89599



More information about the llvm-commits mailing list