[PATCH] D89170: [AMDGPU] Select flat scratch instructions where available

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 09:21:48 PDT 2020


scott.linder added a comment.

I haven't done a meaningful review, but I wanted to note that this will require changes to the debug information (which isn't committed yet). I think this could be as simple as scaling the value of the SP/FP in the DWARF expression to recover the unswizzled scratch address.



================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:368
 
+static unsigned getScracthScaleFactor(const GCNSubtarget &ST) {
+  return ST.enableFlatScratch() ? 1 : ST.getWavefrontSize();
----------------
s/Scracth/Scratch/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89170/new/

https://reviews.llvm.org/D89170



More information about the llvm-commits mailing list