[PATCH] D89497: [LegalizeTypes] Legalize vector rotate operations

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 18 05:55:22 PDT 2020


RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:6293
+  if (IsVectorLowering && (!isOperationLegalOrCustom(ISD::SHL, VT) ||
                         !isOperationLegalOrCustom(ISD::SRL, VT) ||
                         !isOperationLegalOrCustom(ISD::SUB, VT) ||
----------------
RKSimon wrote:
> clang-format this
You need to add the VT.isVector() check as well


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89497/new/

https://reviews.llvm.org/D89497



More information about the llvm-commits mailing list