[PATCH] D89635: [AMDGPU] Correct hsa-diag-v3.s test

Tony Tye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 17 15:10:41 PDT 2020


t-tye created this revision.
t-tye added reviewers: kzhuravl, scott.linder, rampitec.
Herald added subscribers: llvm-commits, kerbowa, tpr, dstuttard, yaxunl, nhaehnle, jvesely.
Herald added a project: LLVM.
t-tye requested review of this revision.
Herald added a subscriber: wdng.

- Use file_check -LABEL markers to prevent false positives being reported due to messages from different tests causing success to be reported.

- Add checks for all the run commands for more robust testing.

- Add checks for the absence of errors.

- Name and order tests more sensibly.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89635

Files:
  llvm/test/MC/AMDGPU/hsa-diag-v3.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89635.298853.patch
Type: text/x-patch
Size: 8349 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201017/ef2fb09e/attachment-0001.bin>


More information about the llvm-commits mailing list