[PATCH] D89628: Don't fold overflowing arithmetic ops on vectors

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:4595
       Result->takeName(&OrigI);
-      Overflow = Builder.getTrue();
+      if (Result->getType()->isVectorTy()) {
+        Overflow = ConstantVector::getSplat(
----------------
This seems like wrong granularity.
I think there should be some method that would return an appropriate i1 or vector of i1 type,
which you'd then just pass into `ConstantInt::getFalse()`/`ConstantInt::getTrue()`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89628/new/

https://reviews.llvm.org/D89628