[PATCH] D89617: Prepend "uniq" to symbol names hash with -funique-internal-linkage-names

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 17 08:05:41 PDT 2020


mtrofin added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/UniqueInternalLinkageNames.cpp:32
+  // this symbol is of internal linkage type.
+  std::string ModuleNameHash = (Twine(".uniq") + Twine(Str)).str();
   bool Changed = false;
----------------
would .uniq. (so a dot before and after) fit more with existing other cases (like .llvm.)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89617/new/

https://reviews.llvm.org/D89617



More information about the llvm-commits mailing list