[PATCH] D88980: [ARM] Basic getArithmeticReductionCost reduction costs

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 17 01:15:37 PDT 2020


dmgreen added inline comments.


================
Comment at: llvm/test/Analysis/CostModel/ARM/mve-vecreduce-add.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py
 ; RUN: opt < %s -S -mtriple=thumbv8.1m.main-none-eabi -mattr=+mve.fp -cost-model -analyze | FileCheck %s
 
----------------
SjoerdMeijer wrote:
> Since you have a `ST->hasMVEIntegerOps()` check, do we need a run with `-mattr=-mve`?
Do you mean, are there tests without MVE? If so yeah, but they are in a different test file and did not change. reduce-add.ll in the same folder contains some other basic tests for Neon and without any vectorization.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88980/new/

https://reviews.llvm.org/D88980



More information about the llvm-commits mailing list