[PATCH] D89613: make the AsmPrinterHandler array public

Jameson Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 22:35:07 PDT 2020


vtjnash added a comment.

In my first attempt, I missed that it's intentional we're claiming `MMI->hasDebugInfo()` if there's information available for DWARF output if using fast-isel, even if we don't need that DebugInfo because the output for it is disabled (CodeView information is still somewhat separate, as my attempt to bring them back in line is what failed the CI testing).  Fortunately, that's what tests are for when this change was added in 8763c0c5b7a566d2fe9476259aa346640b0a9deb (https://reviews.llvm.org/D53885). I think this should pass all tests now, as I've now fully removed that part of the change (it passes locally anyways).

Is it okay if I attempt to re-land this now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89613/new/

https://reviews.llvm.org/D89613



More information about the llvm-commits mailing list