[PATCH] D89497: [LegalizeTypes] Legalize vector rotate operations

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 15:40:13 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3517
   case ISD::ROTR:
-    if (TLI.expandROT(Node, Tmp1, DAG))
+    if (TLI.expandROT(Node, true, Tmp1, DAG))
       Results.push_back(Tmp1);
----------------
Can you add a /*AllowVectorOps*/ comment to the true argument here and at the other call sites to help with readability?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89497/new/

https://reviews.llvm.org/D89497



More information about the llvm-commits mailing list