[PATCH] D89444: [dsymutil] Fix handling of aliases to private external symbols

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 13:29:19 PDT 2020


aprantl added inline comments.


================
Comment at: llvm/tools/dsymutil/MachODebugMapParser.cpp:564
     }
     Section = *SectionOrErr;
+    if ((Section == MainBinary.section_end() || Section->isText()) &&
----------------
bool AliasToPrivateExternal = (SymType & MachO::N_PEXT);
 if ((Section == MainBinary.section_end() || Section->isText()) && ! AliasToPrivateExternal)

?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89444/new/

https://reviews.llvm.org/D89444



More information about the llvm-commits mailing list