[PATCH] D89578: [CostModel] Return TCC_Expensive for non-speculatable ctlz/cttz.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 12:21:46 PDT 2020


fhahn updated this revision to Diff 298717.
fhahn added a comment.



In D89578#2335559 <https://reviews.llvm.org/D89578#2335559>, @spatel wrote:

> Doesn't this affect tests in test/Analysis/CostModel/X86 ?
> We might need to enclose the speculatable -> basic vs. expensive
> difference inside the vector checks.

I originally only updated the simplifycfg checks. Now all impacted tests should be updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89578/new/

https://reviews.llvm.org/D89578

Files:
  llvm/include/llvm/CodeGen/BasicTTIImpl.h
  llvm/test/Analysis/CostModel/X86/cttz.ll
  llvm/test/Analysis/CostModel/X86/intrinsic-cost-kinds.ll
  llvm/test/CodeGen/X86/dagcombine-select.ll
  llvm/test/Transforms/SLPVectorizer/X86/cttz.ll
  llvm/test/Transforms/SimplifyCFG/X86/speculate-cttz-ctlz.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89578.298717.patch
Type: text/x-patch
Size: 25920 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201016/32caa914/attachment.bin>


More information about the llvm-commits mailing list