[PATCH] D89576: [SVE][CodeGen] Lower scalable masked scatters

Kerry McLaughlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 11:25:21 PDT 2020


kmclaughlin created this revision.
kmclaughlin added reviewers: sdesmalen, efriedma, fhahn, paulwalker-arm.
Herald added subscribers: llvm-commits, ecnelises, steven.zhang, psnobl, hiraditya, tschuett.
Herald added a project: LLVM.
kmclaughlin requested review of this revision.

Lowers the llvm.masked.scatter intrinsics (scalar plus vector addressing mode only)

Changes included in this patch:

- Adds the IsTruncatingStore flag to MaskedScatterSDNode, set by getMaskedScatter()
- Added refineIndexType() to DAGCombine which folds a sext/zext of the index into the index type. Also added refineUniformBase() which gets the base pointer and index from an add + splat_vector.
- Custom lowering for MSCATTER, which chooses the appropriate scatter store opcode to use. Floating-point scatters are cast to integer, with patterns added to match FP reinterpret_casts.
- Print details of MaskedScatterSDNodes (is truncating, signed or scaled) in SelectionDAGDumper
- Tests with 32 & 64-bit scaled & unscaled offsets


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89576

Files:
  llvm/include/llvm/CodeGen/SelectionDAG.h
  llvm/include/llvm/CodeGen/SelectionDAGNodes.h
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
  llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.h
  llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/test/CodeGen/AArch64/sve-masked-scatter-32b-scaled.ll
  llvm/test/CodeGen/AArch64/sve-masked-scatter-32b-unscaled.ll
  llvm/test/CodeGen/AArch64/sve-masked-scatter-64b-scaled.ll
  llvm/test/CodeGen/AArch64/sve-masked-scatter-64b-unscaled.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89576.298683.patch
Type: text/x-patch
Size: 66181 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201016/65b03f29/attachment.bin>


More information about the llvm-commits mailing list