[PATCH] D88420: [InstCombine] matchFunnelShift - support non-uniform constant vector shift amounts (PR46895)

Fri Oct 16 10:35:40 PDT 2020

MaskRay added subscribers: nemanjai, MaskRay.
MaskRay added a comment.

In D88420#2335176 <https://reviews.llvm.org/D88420#2335176>, @lebedev.ri wrote:

> In D88420#2335173 <https://reviews.llvm.org/D88420#2335173>, @saugustine wrote:
>
>> It is a miscompile--or, at least a fingerprint is being miscomputed. The failure check is here:
>>
>> https://boringssl.googlesource.com/boringssl/+/refs/heads/master/crypto/hrss/hrss_test.cc#165
>>
>> But that is obviously somewhat removed from where things actually went wrong, which is what I'm (rather slowly, unfortunately) trying to figure out.
>
> I think there were some related fixes afterwards. Is the issue still present in master?

Still present as of 51ff04567b2f8d06b2062bd3ed72eab2e93e4466 <https://reviews.llvm.org/rG51ff04567b2f8d06b2062bd3ed72eab2e93e4466>.

Adding @nemanjai in case he can find anything obvious.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88420/new/

https://reviews.llvm.org/D88420