[PATCH] D89189: [ARM][MachineOutliner] Do not overestimate LR liveness in return block

Yvan Roux via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 05:53:55 PDT 2020


yroux added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5730
+    // Check defs of LR.
+    if (MI.modifiesRegister(ARM::LR, nullptr))
+      Live = false;
----------------
I think we can get ride of passing nullptr since it is TRI default value in the prototype


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5743
+    }
+    if (MI.readsRegister(ARM::LR, nullptr))
+      Live = true;
----------------
likewise


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89189/new/

https://reviews.llvm.org/D89189



More information about the llvm-commits mailing list