[PATCH] D81766: [VectorCombine] try to create vector loads from scalar loads

[Artem Belevich via Phabricator via llvm-commits]

tra added subscribers: yaxunl, tra.
tra added a comment.

FYI: @yaxunl -- I've ran into this while compiling rocFFT, so it may bite you, too.



================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:105
+  // TODO: Extend this to match GEP with constant offsets.
+  Value *PtrOp = Load->getPointerOperand()->stripPointerCasts();
+  assert(isa<PointerType>(PtrOp->getType()) && "Expected a pointer type");
----------------
This triggers an assertion in `CreateBitCast` below when we happen to strip a necessary `AddrSpaceCast` and put `PtrOp` in a different AS.

Reproducer is here:
https://gist.github.com/Artem-B/98a4420dda4f0c36364ddc170a8b12c5

At the very least the code should check that AS didn't change.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81766/new/

https://reviews.llvm.org/D81766