[PATCH] D86021: [IR] Make nosync, nofree and willreturn default for intrinsics.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 10:33:00 PDT 2020


jdoerfert accepted this revision.
jdoerfert added a comment.

LGTM. We can change the name later if we need to.
This is now "opt-in" and (IIRC) we addressed all the known issues.



================
Comment at: llvm/include/llvm/IR/Intrinsics.td:359
 
+class DefaultIntrinsic<list<LLVMType> ret_types,
+                list<LLVMType> param_types = [],
----------------
jdoerfert wrote:
> Add a comment here describing the difference to the class above.
Nit, `= 0`

Also, remove `disable_default_attributes` from the template args and pass 0 right away. No need to overwrite it by a user, they have `Intrinsic` for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86021/new/

https://reviews.llvm.org/D86021



More information about the llvm-commits mailing list