[PATCH] D89420: [lld-macho][easy] Fix segment max protection

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 08:47:03 PDT 2020


compnerd added inline comments.


================
Comment at: lld/MachO/OutputSegment.cpp:36
+         "TODO: i386 has different maxProt requirements");
+  return initProt(name);
 }
----------------
It seems that it would be better to replace `initProt` and `maxProt` with just `prot`?  Or just filling in the differences that require this would be a good idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89420/new/

https://reviews.llvm.org/D89420



More information about the llvm-commits mailing list