[PATCH] D84380: [lit] Support running tests on Windows without GnuWin32.

Adrian McCarthy via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 08:42:26 PDT 2020


I have no reason to suspect those patches in particular.  I did a huge git
bisect, which turned up nothing.  Older versions that used to work no
longer worked by the time the bisect worked that far back.  That makes me
think it might be incomplete dependency checking:  Something goes bad, and,
instead of rebuilding it, the bad result is re-used in each subsequent
build.

The 37 tests that I fixed were due to a lit config template that mangled
one of the zillion Python home environment variables because it failed to
escape the backslashes in a Windows path (which is what made me suspect a
connection to this patch).  But I cannot explain why that hasn't been a
problem since last December when the error was committed.

The entire log is over 10,000 lines.  In a random sampling, most of the
remaining failures look like FileCheck miscompares, as though the tests are
catching real problems.  Other than that, I don't see a pattern.  I'll be
working on this today, and, if I'm still stumped, I'll start a separate
thread with examples from the log.

On Wed, Oct 14, 2020 at 1:23 PM Alexandre Ganea via Phabricator <
reviews at reviews.llvm.org> wrote:

> aganea added a comment.
>
> In D84380#2330715 <https://reviews.llvm.org/D84380#2330715>, @amccarth
> wrote:
>
> > I ask because I'm still trying to figure out why 899 LLDB tests started
> failing for me on Friday.  (Actually, it was 936 tests, but I fixed 37 of
> them with a fix to a line that was introduced almost a year ago.  I have
> not idea why the problems just started appearing on the 9th.)
>
> Adrian, can it be rG97e7fbb343e2a4ea913686254105b9965c5468f8 <
> https://reviews.llvm.org/rG97e7fbb343e2a4ea913686254105b9965c5468f8> or
> rG79809f58b02419a5d1bfb6c9a59dbd13cd038c77 <
> https://reviews.llvm.org/rG79809f58b02419a5d1bfb6c9a59dbd13cd038c77>?
> What errors do you see? Can you paste the log?
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D84380/new/
>
> https://reviews.llvm.org/D84380
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201015/25050be8/attachment.html>


More information about the llvm-commits mailing list