[lld] 9803cf5 - [LLD] [COFF] Fix a condition that was missed in 7f0e6c31c255. NFC.

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 08:34:11 PDT 2020


Author: Martin Storsjö
Date: 2020-10-15T18:34:01+03:00
New Revision: 9803cf57d6fe5c7189255ad74b289c2a0d4a8a6a

URL: https://github.com/llvm/llvm-project/commit/9803cf57d6fe5c7189255ad74b289c2a0d4a8a6a
DIFF: https://github.com/llvm/llvm-project/commit/9803cf57d6fe5c7189255ad74b289c2a0d4a8a6a.diff

LOG: [LLD] [COFF] Fix a condition that was missed in 7f0e6c31c255. NFC.

This should fix cases when e.g. auto import is enabled without
mingw mode in total being enabled.

Differential Revision: https://reviews.llvm.org/D89006

Added: 
    

Modified: 
    lld/COFF/SymbolTable.cpp

Removed: 
    


################################################################################
diff  --git a/lld/COFF/SymbolTable.cpp b/lld/COFF/SymbolTable.cpp
index 173e32f628ef..138450a4b15a 100644
--- a/lld/COFF/SymbolTable.cpp
+++ b/lld/COFF/SymbolTable.cpp
@@ -402,7 +402,7 @@ void SymbolTable::reportUnresolvable() {
     }
     if (name.contains("_PchSym_"))
       continue;
-    if (config->mingw && impSymbol(name))
+    if (config->autoImport && impSymbol(name))
       continue;
     undefs.insert(sym);
   }


        


More information about the llvm-commits mailing list