[PATCH] D89330: [RISCV] [TableGen] Modify RISCVCompressInstEmitter.cpp to use getAllDerivedDefinitions()

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

In D89330#2332401 <https://reviews.llvm.org/D89330#2332401>, @Paul-C-Anagnostopoulos wrote:

> I do not want the revision to close when I push the patch. I'm using Phabricator to keep track of the status of each patch, so I want to close the revision once I know that the patch built correctly.
>
> Can I cross-link the commit and revision without closing the revision?

Please do not do that, that is not how Phabricator is meant to be used. You can update the Phabricator metadata, but you cannot update the commit once pushed, and it is really important that people be able to look at a commit and get the link to the Phabricator review in order to be able to see the discussion for why the patch ended up the way it did.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89330/new/

https://reviews.llvm.org/D89330