[PATCH] D85749: [DebugInstrRef][4/9] Support recording of instruction reference substitutions

[Jeremy Morse via Phabricator via llvm-commits]

jmorse reopened this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

After landing this, bkramer pointed out one of the assertions in substituteDebugValuesForInst was ineffective. Fixing that shows that some callers (see patch 5 in this series) do so with different instruction signatures (i.e., different types and different numbers of operands).

I've revised the method in the patch I'll upload in a few seconds to optionally allow a "number of operands to substitute" to be specified. This makes use of the LLVM convention that register defs are usually the first operands: we can say for the arithmetic-to-LEA code paths (patch 5) that only the first operand needs to be substituted.

I don't think this changes the fundamental idea of this patch, only the way it's expressed. I'll leave this up for a few days and then land.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85749/new/

https://reviews.llvm.org/D85749