[PATCH] D89288: [RISCV] Enable the use of the old sptbr name

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.
Herald added a subscriber: NickHung.

I think there's a little more to supporting older names than just the date of the spec. I agree that we don't expect anyone doing serious RISC-V work to be working to the 1.9 spec (unless there are cores taped out with that spec we don't know about), but in cases where there have been CSR renames it's often the case that people migrate to newer specification versions but don't always change the naming. There's an argument for the compiler complaining at them in this case, but there's also the user experience issue. It looks like the RISC-V compliance suite for instance still uses the sptbr name https://github.com/riscv/riscv-compliance/issues/107

Adding older aliases if they're found to be an issue in the wild is I think a policy that is worth considering alongside the alternate policies of adding all such aliases, or none of them (an encouraging people to update their code).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89288/new/

https://reviews.llvm.org/D89288