[PATCH] D89392: [GlobalISel] Fold unary opcodes in CSEMIRBuilder

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 01:07:50 PDT 2020


foad added a comment.

In D89392#2330590 <https://reviews.llvm.org/D89392#2330590>, @aditya_nandakumar wrote:

> I attempted this in the past but abandoned it due to infinite loops in legalization like mentioned earlier. Constant folding during legalization seems okay as long as it operates on legal types (ie fold an operation of constants (which are already legal) to the same type.

OK, perhaps I will have to abandon this too. But it would be nice to somehow get the codegen improvements shown in some of the MIPS and X86 tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89392/new/

https://reviews.llvm.org/D89392



More information about the llvm-commits mailing list