[PATCH] D88684: llvm-reduce: Don't replace intrinsic calls with undef

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceFunctions.cpp:38
+            // change codegen.
+            return !F.isIntrinsic() && !O.shouldKeep();
+          });
----------------
lebedev.ri wrote:
> Much like in ReduceAttributes, i don't think we should rely on the `@llvm.` function name prefix,
> but should actually check that they are intrinsics, i.e.
> `F.getIntrinsicID() != Intrinsic::not_intrinsic`
The special operand properties are based on the llvm. prefix in the verifier, so I think this is the correct check here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88684/new/

https://reviews.llvm.org/D88684