[PATCH] D88215: Add llvm.loop.unroll.threshold metadata

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

As implemented, the threshold is specific to the AMDGPU backed. Any possibility to implement it generally in `LoopUnrollPass.cpp`? If it is indeed intended to just by processed by a single backend, the attribute's name should reflect that, like for the `amdgpu-unroll-threshold` attribute.

The patch is identical to D84779 <https://reviews.llvm.org/D84779>? The same concerns to the undefined semantics for "threshold" still applies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88215/new/

https://reviews.llvm.org/D88215