[PATCH] D89400: [SimplifyLibCalls] Keep calling convention when simplifying to libcall

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

In general, if TargetLibraryInfo says a library function is available, that means it's available with the C calling convention.  Copying the calling convention from some other call shouldn't be necessary.  In general, there is no call to copy the calling convention from.

I'd recommend taking a closer look at why these markings exist in the first place.  My first impression is that clang is doing something wrong: it shouldn't be marking up calls to C library functions with a non-C calling convention.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89400/new/

https://reviews.llvm.org/D89400