[PATCH] D89371: [NPM] Port -loop-versioning-licm to NPM

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopVersioningLICM.cpp:148
+  LoopVersioningLICM(AliasAnalysis *AA, ScalarEvolution *SE,
+                     LoopAccessLegacyAnalysis *LAA, LoopAccessInfo *LAI,
+                     OptimizationRemarkEmitter *ORE)
----------------
aeubanks wrote:
> is the `LoopAccessLegacyAnalysis` necessary? Can `LoopVersioningLICM` only need the `LoopAccessInfo` passed in from callers? Looks like both the legacy and NPM pass can create the proper `LoopAccessInfo`.
I meant can we can treat `LoopAccessInfo` just like the other analyses like `DominatorTree`?
Creating it inside `LoopVersioningLICMPass::run`/`LoopVersioningLICMLegacyPass::runOnLoop` rather than passing a `function_ref`. So `GetLAI` is unnecessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89371/new/

https://reviews.llvm.org/D89371