[PATCH] D89356: [cmake] Limit missing external lit warning to be shown once

Dave Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 13 19:09:34 PDT 2020


kastiglione added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:1661
         return()
-      else()
+      elseif (NOT DEFINED CACHE{LLVM_EXTERNAL_LIT_MISSING_WARNED_ONCE})
         message(WARNING "LLVM_EXTERNAL_LIT set to ${LLVM_EXTERNAL_LIT}, but the path does not exist.")
----------------
JDevlieghere wrote:
> This should probably be of type `INTERNAL` which is the same as `CACHE` but without the (G)UI entry. 
nice, done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89356/new/

https://reviews.llvm.org/D89356



More information about the llvm-commits mailing list