[PATCH] D89288: [RISCV] Enable the use of the old sptbr name

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 13 17:08:49 PDT 2020


jrtc27 added a comment.

To elaborate:

Any serious RISC-V codebase using S-mode needs to be updated to the more recent privilege spec versions if it wants to have any hope of not being lost to the ages as the ecosystem is still moving quite quickly. 1.9 is very outdated now, with both 1.10 and 1.11 having been published since (and 1.11 ratified) and further changes defined in the draft 1.12. It is a waste of time to support CSR names that were outdated even 2 years ago, and merely encourages sloppy coding practice where the old names continue to be used. Also unlike GNU binutils we are also currently unable to distinguish between ISA versions so we can't warn like it will (if you enable the feature) if you use an old CSR name. Finally, if you really want to support version 1.9, be consistent and do the whole thing or nothing at all, but don't just pick and choose specific aspects of it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89288/new/

https://reviews.llvm.org/D89288



More information about the llvm-commits mailing list